Skip to content

docs: update forwarded_allow_ips to Markdown#3494

Open
Juneezee wants to merge 4 commits intobenoitc:masterfrom
Juneezee:docs/forwarded_allow_ips
Open

docs: update forwarded_allow_ips to Markdown#3494
Juneezee wants to merge 4 commits intobenoitc:masterfrom
Juneezee:docs/forwarded_allow_ips

Conversation

@Juneezee
Copy link
Contributor

@Juneezee Juneezee commented Feb 10, 2026 •
edited
Loading

https://gunicorn.org/reference/settings/#forwarded_allow_ips is still using reStructuredText

Before:

before

After:

after

@Juneezee
docs: update forwarded_allow_ips to Markdown
fb698ef 
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@benoitc
Copy link
Owner

benoitc commented Feb 10, 2026

settings.md is generated from settings.py , can you fix the issue there?

@Juneezee
Update config.py
cc974da 
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@Juneezee
Copy link
Contributor Author

Juneezee commented Feb 10, 2026

settings.md is generated from settings.py , can you fix the issue there?

@benoitc I believe you meant config.py. I have updated the code there and also ran scripts/build_settings_doc.py to double-check. Please take a look again. Thank you.

@benoitc
Copy link
Owner

benoitc commented Feb 11, 2026

settings.md is generated from settings.py , can you fix the issue there?

@benoitc I believe you meant config.py. I have updated the code there and also ran scripts/build_settings_doc.py to double-check. Please take a look again. Thank you.

Yes you're right settings.py thanks for the change!

Juneezee
Juneezee commented Feb 11, 2026
View reviewed changes
@Juneezee
Use markdown-grid-tables for multiline table
c095960 
pycodestyle enforces 120-character line lengtn limit.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@benoitc
Copy link
Owner

benoitc commented Feb 12, 2026

using the extensino is fine for me. I prefer to break lines for readability :)

@Juneezee
Enable hard_linebreaks
54eb411 
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@Juneezee Juneezee requested a review from benoitc February 13, 2026 01:35
Juneezee
Juneezee commented Feb 13, 2026
View reviewed changes
mkdocs.yml
Comment on lines +108 to +109
- markdown_grid_tables:
hard_linebreaks: true
Copy link
Contributor Author

@Juneezee Juneezee Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using the extensino is fine for me. I prefer to break lines for readability :)

👍 . I have updated the PR.

2026-02-12_00-07

Copy link
Contributor Author

@Juneezee Juneezee Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benoitc friendly ping 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benoitc benoitc Awaiting requested review from benoitc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Juneezee @benoitc